search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 68 forks source link

Feature request: support dark themes #34

Closed NickCraver closed 6 years ago

NickCraver commented 6 years ago

First: I love this extension!

I know the title is scary, but I propose a simplistic solution to make life better for dark GitHub users in a hurry. Here's what I'm doing locally:

.icon .octicon:before {
    filter: brightness(125%) contrast(150%) drop-shadow(0 0 0 #fff) drop-shadow(1px 1px 1px #444);
}

I'm sure a designer could do far better than I, but something like this rigged to a "Dark Mode" checkbox in the options would make it super simple for those with dark themes to have much better looking icons.

Here's a compare on my machine of extension+dark vs. extension+dark+tweak above: compare

I think it's hard to tell in a 2:1 block up issue picture, but they're far more readable on a HiDPI screen. I'm not saying use my styling (though you're welcome to), but I just wanted to pitch the idea in general: a checkbox hooked to a CSS tweak to improve life a bit.

Thoughts?

homerchen19 commented 6 years ago

Great suggestion! I like this improvement, but I'm busy these weeks. PR is always welcome, or I will do it later.