search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 68 forks source link

Remove unused browser_action #37

Closed yfdyh000 closed 6 years ago

homerchen19 commented 6 years ago

Hi @yfdyh000 Could you provide some information about why browser_action is unused? Thx.

yfdyh000 commented 6 years ago

It has no action in the code and user clicked, unless it is right clicked. Maybe it should be disabled on not github.com, and/or provide the options page when the user clicked.

homerchen19 commented 6 years ago

Got it, but I still consider it's existence. It already has some options, and it would be better if the option page can pop out when user clicks the icon 😄

homerchen19 commented 6 years ago

I just added popup page in PR #38, so this PR can be closed.