search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 68 forks source link

allow icons to be set on private gitlab instances #49

Closed kg6zvp closed 5 years ago

kg6zvp commented 5 years ago

GitLab is often run on private server instances. These modifications allow this extension to work on GitLab instances which are not gitlab.com

kg6zvp commented 5 years ago

I made a couple of code changes. Please see updated diff. Thanks for the add-on. :+1:

homerchen19 commented 5 years ago

Thanks. Another thought, this PR is a bit related to #2 And I believe https://github.com/xxhomey19/github-file-icon/issues/2#issuecomment-369619283 is the best solution for the feature. Anyway, in order to activate this add-on for all private server instance URL, building a general functionality is better than only working on GitLab private server. I'll be so excited if this feature is implemented.

kg6zvp commented 5 years ago

I saw that. However, it's quite nice not to have to intervene and have to set it up. As someone who uses many different machines, having to set the information up on many different domains after switching machines (as I must on other add-ons) is quite a burden.

I agree that #2 is great, but it seemed out of scope and different in nature than what I was trying to fix.

homerchen19 commented 5 years ago

Yeah I got your point. However, to be honest, instead of fixing this issue, I prefer to develop a new feature to solve all similar issues at once. In short, if this PR couldn't solve #2 I would close it, and I will either implement by myself or wait someone does it. Hope you understand :)