search

homerchen19 / github-file-icons

šŸŒˆ šŸ—‚ A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 68 forks source link

Question: Why settings in Popup menu? #50

Closed Jackymancs4 closed 5 years ago

Jackymancs4 commented 5 years ago

Hello @xxhomey19 Only now I noted this change, introduced by https://github.com/xxhomey19/github-file-icon/commit/91fce311fbf21fa061fe8f0bf22fbd64e2398d9a.

I was wondering if you can share the rationale behind your decision. It feels to me a little "wrong" to move settings from a place meant for settings to a place like the user popup, meant instad to provide high level interaction and to show off-page informations.

Given the static nature of the addon and the relatively low frequency of settings change I thing most users do, I think having one more action icon is a pretty much uneeded. Just a thought of mine.

Thanks.

homerchen19 commented 5 years ago

Hi @Jackymancs4 It used to be in the option page. At that moment I thought modifying the settings in the action page is more intuitively than modifying it in the option page. Actually, I'm not quite confident about that decision now haha. I take a look at other extensions I have installed, and I found some of them put their settings in the action page as well. So in my view, it's fine to either put it in the action or the option page. I'm ok with anything.

homerchen19 commented 5 years ago

Iā€™m closing this issue because it has been inactive for a few months.

homerchen19 commented 5 years ago

The popup window is removed on version 0.8.0. After referring to a few extensions, I believe showing options in a context menu is more correct than a customized popup menu.

testman42 commented 5 years ago

I would then ask further question here: Is there a way to disable the context menu? Because I really don't plan on changing the settings and there is absolutely no reason for me to have those options easily accessible.

Or maybe for someone who actually intends to use this functionality, make it so that it appears only on relevant sites and not on every website? Is that something that contexts: ['all'] regulates?

homerchen19 commented 5 years ago

Hi @testman42 Right, I agree with your points, and I guess contexts: ['all'] may be a mistake. Furethermore, I probly should add documentUrlPatterns option to restrict the context menu to only show up on specific pages. I'll fix it asap. Many thanks!

homerchen19 commented 5 years ago

@testman42 The changes have been made on version 0.8.1