Icons aren’t replacing the default one on the project root/home.

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.

https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe

MIT License

1.46k stars 70 forks source link

Icons aren’t replacing the default one on the project root/home. #59

Closed bobaikato closed 4 years ago

bobaikato commented 5 years ago

https://github.com/B0BAI/Gemfire-REST-API-Example

https://github.com/B0BAI/Server-Sent-Event-Demo

Even my private repo have that issue.

bobaikato commented 5 years ago

There is probably a conflict with Octotree plugin.

homerchen19 commented 5 years ago

I don't installed Octotree, and those repos look fine from my browser. So the icons look fine if you turn off Octotree?

bobaikato commented 5 years ago

Yeah, if Octotree is off everything is fine

But if I turn it on, it messes up.

homerchen19 commented 5 years ago

Got it. Thanks for reporting this issue.

enricoreich commented 5 years ago

I don't have this issue with octotree but with refined github.

File Icon for GitHub, GitLab and Bitbucket: v0.8.1 octotree: v3.0.7 refined github: v19.4.26.1909

janat08 commented 5 years ago

https://github.com/sindresorhus/refined-github/issues/1993#issuecomment-487423210 Suggests a fix that improves compatibility.

fregante commented 5 years ago

This has been fixed in https://github.com/sindresorhus/refined-github/commit/fedcb021f6c99cb811a0b8ec52dd29f6a9102df9 but github-file-icon will have to deal with the jumping on :hover caused by their taller icons:

However these two suggestions still apply, to ensure it works regardless of the order of execution:

add a octicon-file class to their new icon (so RGH can wrap it in a link)

place replace the existing .octicon-file element (so it replaces it in the correct position, if RGH already run)

FranklinYu commented 5 years ago

@B0BAI Why close it? Is it fixed?

bobaikato commented 5 years ago

No, not fix. I wonder if someone will give an update on the issue. I have since decided to not the github-file-icon lib.

homerchen19 commented 4 years ago

Just tested on my chrome. This issue seems to be fixed now. I installed both extensions, and everything works pretty well.

FranklinYu commented 4 years ago

I thought the intention was to leave this issue open until the two bullet points from @fregante are implemented? Currently it was worked around on RGH side (according to the comment above), but it’s brittle. For example it still doesn’t work for me.