Closed fregante closed 5 years ago
@fregante Thanks for the help!
But I got this warning when I loaded the extension in my Chrome.
It's from here: https://github.com/fregante/webext-dynamic-content-scripts/blob/1fa71872232886a92d2743a63a832de9e01ff72b/index.ts#L18 Do you have any idea how to solve this?
Also I think we could put
"optional_permissions": [
"http://*/*",
"https://*/*"
],
into manifest.json
, which is the same as refined-github.
Oops! I need to change that.
But also I suggest to use webextensions-polyfill
at some point. Promised APIs are great
Fixed both points
Thanks! But there are two issues I found
ReferenceError: browser is not defined
still occurs when running into this line.
https://github.com/fregante/webext-dynamic-content-scripts/blob/master/index.ts#L23webNavigation
can't be removed because Bitbucket seems to use history.pushState()
to navigate, so content script can't be triggered without listening for onHistoryStateUpdated.Line 28 doesn't appear in the final file, it's just TypeScript information Line 23: I had tried the script but I didn't see that issue. 😅
I just published 6.0.3-0, can you install it with npm i webext-dynamic-content-scripts@next
?
You don't need webNavigation
but something like pjax:end
on GitHub, you don't want to inject the whole script every time the page changes.
I don't know the exact event BitBucket fires but there's a very generic popstate
you can listen to in content.js
, without extra permissions.
webext-dynamic-content-scripts
in package.json
isn't updated. Could you update it?
Closes https://github.com/xxhomey19/github-file-icon/issues/2 Closes https://github.com/xxhomey19/github-file-icon/issues/55
Implemented like in Refined GitHub.
I skipped the tests because: