Ajax observer appears to be broken

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.

https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe

MIT License

1.42k stars 68 forks source link

Ajax observer appears to be broken #72

Closed stevelacey closed 4 years ago

stevelacey commented 4 years ago

The icons load, and stay, on a fresh page load, or a hard refresh / cached page load, but clicking into directory and triggering ajax results in a flash of icons then back to the generic icons.

Tested on Chrome 80.0.3987.106 (Official Build) (64-bit)

homerchen19 commented 4 years ago

Hi @stevelacey

I've tried to fix this issue this afternoon, but it somehow still doesn't work :( I have referenced some code from https://github.com/sindresorhus/hide-files-on-github/blob/master/source/content.tsx#L103 and https://github.com/sindresorhus/refined-github/blob/master/source/libs/on-file-list-update.ts. However, none of them can solve this issue. Maybe this happens because of changes on the GitHub side.

AlexWayfer commented 4 years ago

Also after "Back" button in browser.

kidonng commented 4 years ago

This extension seems to handle it well.

homerchen19 commented 4 years ago

It seems to be fixed by #76. Big thanks to @sodatea, feel free to reopen this if the issue still happens.