search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.42k stars 68 forks source link

BUG: Dual icons when using back button #85

Closed theS1LV3R closed 4 years ago

theS1LV3R commented 4 years ago

If you use the back button to go back to the file list (from a file or folder for example) the icons become duplicated. When you hover over them, this issue disappears. The issue reappears once you stop hovering.

Example

homerchen19 commented 4 years ago

Hi @ent3r, this doesn't happen to me. Could you try turning off other extensions which are also running on GitHub pages, and see if this bug still appears?

theS1LV3R commented 4 years ago

Hmm... Yeah, this happens when using sindresorhus/refined-github along with github file icons. What would be the process if this should be fixed?

Hacksore commented 4 years ago

I experimented with the following, is it a good solution? Seems to fix it for me when using my patched version of https://github.com/homerchen19/github-file-icons and the latest https://github.com/sindresorhus/refined-github/.

image https://github.com/homerchen19/github-file-icons/blob/master/src/ts/content.ts#L141

homerchen19 commented 4 years ago

Fix it in version 1.1.2 Thanks guys!