search

homerchen19 / nba-go

🏀 💻 The finest NBA CLI.
https://www.npmjs.com/package/nba-go
MIT License
3.71k stars 221 forks source link

Highlighting game highs for each category #43

Closed ChristianLapinig closed 7 years ago

ChristianLapinig commented 7 years ago

In the team box score, I know that it highlights the play with the most points as shown below

screenshot from 2017-11-12 22-22-48

I was wondering if highlighting the high of each category would be cool.

homerchen19 commented 7 years ago

Hi @ChristianLapinig , well, actually, each category will be highlighted when its number is over its own standard (I decided the standard). For instance, MIN is 35, +/- is 15 and PTS is 20. I'm not sure whether this is a good way or not. Maybe people want to highlight the highest number of each category. This could have more discussions.

jhamet93 commented 7 years ago

Personally, If I'm scanning the box score I would want the highest in each category highlighted. Not sure a hardcoded threshold is obvious to end users.

ChristianLapinig commented 7 years ago

@xxhomey19 I or someone can work on this and send a PR if it's ok with you.

homerchen19 commented 7 years ago

@ChristianLapinig

Sure, it's fine with me.

homerchen19 commented 7 years ago

Closed by #51