search

homerchen19 / nba-go

🏀 💻 The finest NBA CLI.
https://www.npmjs.com/package/nba-go
MIT License
3.71k stars 222 forks source link

about chinese language #45

Open ivanmissu opened 6 years ago

ivanmissu commented 6 years ago

my english is poor , consider chinese language package ?

homerchen19 commented 6 years ago

@ivanmissu

of course, but that will be a tough work.

ivanmissu commented 6 years ago

@xxhomey19 thanks for contribution

homerchen19 commented 6 years ago

I think this is low priority. This won't be done in the near future. Furthermore, some terms are translated differently between simplified Chinese and traditional Chinese. I prefer to develop traditional Chinese first.

hkongm commented 6 years ago

consider add the localization setting?

homerchen19 commented 6 years ago

@hkongm That would be good.

Kthulu120 commented 6 years ago

I mean we can have a short term solution in google translate (translation may be spotty) if using localization setting isn't enough

1yzz commented 5 years ago

Visit https://china.nba.com/static and you'll find useful data. https://china.nba.com/static/data/game/playbyplay_0041800224_4.json i18n would not be that hard to implement (maybe add a map to player name, team name and event type and that sort of things), but this just seems unnecessary.