homeroom-live / homeroom

Live streaming for education.
0 stars 0 forks source link

Missing Dashboard implementation #7

Closed maticzav closed 6 years ago

maticzav commented 6 years ago

This is an issue for tracking dashboard integration progress.

Functionality

@maticzav

  • [x] Classrooms
  • [x] orderBy and last: 3 Classes
  • [ ] Classroom
  • [ ] Paginated Classes
  • [x] Create Classroom
  • [ ] Class
  • [ ] Messages
  • [ ] Create Class
  • [x] Schema Updates
  • [x] Classroom picture
  • [x] Classroom video
  • [x] Classroom teacher -> teachers

Styling

@hoodsy

hoodsy commented 6 years ago

@maticzav starting a list of schema adjustments

hoodsy commented 6 years ago

@maticzav getting close for Dashboard! I haven't checked yours off because Files are needed for almost every screen, and there is some Mutation wiring we need to do.

Curious to see how you would like to set up Messages as well.

Do you mind walking through Classrooms Query with 3 most recent/upcoming classes per classroom with me? Should be quick and simple, I'm just not sure how to pass arguments to queries with the new api, e.g. last: 3, sort.

maticzav commented 6 years ago

Sure thing! I wonder though what you have in mind with additional wiring?

I removed sort property altogether as it's commonly taken as a bad practice to have such a flexible schema. Currently, you can load classes and paginate them irrationality easily - I can show you that as well. Maybe we could jump on a call later today to arrange this questions?

Besides that, have you tried using Playground for schema exploration? I can tell you how to do just about everything, but I feel like once you're in control it feels 100% better. Tell me if you need any help! 😄

hoodsy commented 6 years ago

Playground is a game changer, schema is 10x easier to reason about now 😅

I'm thinking some Class will have a subset of teachers from Classroom... potentially even a teacher from outside the Classroom if they just wanted someone to come and moderate the chat for a stream.

You know what I'm saying? Right now there's only teachers on Classroom, which is basically the Classroom admins. Individual Class may have different teachers.

We won't support this teacher flexibility for launch anyways, but something to keep in mind

maticzav commented 6 years ago

Yea I thought so as well! Maybe we should still consider a bit more about this before launch.

I see two options here; add editors field afterwards or add an admin field right away. I feel like the first one makes less sense since they are all teachers - not indeed editors in the true meaning of the word. The second one also makes more sense once we add remove teacher functionality - we don't want the admin/creator to be removed, don't we?

hoodsy commented 6 years ago

No we wouldn't... This will have to be a full blown feature at some point where you have a typeahead search to add users, who could be: owner, admin, creator, and moderator, from most to least privileges.