search

hometown-fork / hometown

A supported fork of Mastodon that provides local posting and a wider range of content types.
GNU Affero General Public License v3.0
743 stars 55 forks source link

pinned private replies shown as public #1178

Closed stillnotstars closed 1 year ago

stillnotstars commented 2 years ago

Steps to reproduce the problem

  1. make a public post
  2. make a private reply and pin it
  3. look at it in a private window and realize you can see the private post without logging in: image
  4. despair

Expected behaviour

be unable to see the post unless logged in

Actual behaviour

post is visible

Specifications

v1.0.6+3.5.2

ghost commented 2 years ago

I can reproduce this on Hometown v1.0.6+3.5.2, but can't on Mastodon v3.5.3.

As it doesn't seems to be something that was happening on Mastodon at all, not present in any changelog (see v3.5.3: https://github.com/mastodon/mastodon/releases/tag/v3.5.3), it would likely be a bug introduced in Hometown modifications. 🫤

Cassolotl commented 1 year ago

I came here to report this, spotted on creacher.club, v1.0.5+3.5.2.

johnholdun commented 1 year ago

Just submitted a PR that fixes this issue. It looks like the filtering for local-only statuses managed to conflict with the filtering for private statuses.