search

hometown-fork / hometown

A supported fork of Mastodon that provides local posting and a wider range of content types.
GNU Affero General Public License v3.0
736 stars 56 forks source link

A few issues on the server about page #1287

Open Ragzouken opened 1 year ago

Ragzouken commented 1 year ago

Steps to reproduce the problem

Go to the about page of your hometown server.

Expected behaviour

No sign-in button if logged in, no "moderated servers" clickable in sidebar, no default scrollbars for server urls.

Actual behaviour

Inverse of above

Detailed description

  1. "sign in" button even when logged in
  2. near-empty sidebar with clickable "moderated servers" link that doesn't do anything
  3. server urls have horizontal and vertical scrollbars even though they don't overflow (.rich-formatting table td.nowrap span has overflow: scroll rather than overflow: auto?)

Not sure if signing in is actually supposed to change what information is available on the page. Realising now that maybe that sidebar is supposed to be a contents page? With just one item and no heading this is very unclear.

image

Specifications

v4.0.2+hometown-1.1.1 firefox 108.0.2 (64-bit) on windows 10

dariusk commented 1 year ago

Sign in button is an issue I'll fix. Overflow thing is a CSS bug I will fix.

The near-empty sidebar is there because you include no HTML headers in your server description. The intent is to parse out all the sections of your server description and include a table of contents for them. I should describe this functionality somewhere for sure. Does it seem like a bug now that you know the intent? If you have no headers should I just... get rid of the sidebar?

Ragzouken commented 1 year ago

Oh, I see. I think one thing that confused me is that the anchor tag for the single header there was #unavailable-content which, not matching the actual text of the header (and sounding like something is missing or unloaded or not permitted), made me think "oh huh something must be broken".

I can see the benefit of keeping it even if there aren't any headers, to provide discoverability -- but as-is I just didn't realise what it was doing. If it had a heading of "Contents" or similar I think I would have understood. Of course I'm not opposed to just hiding it either.