search

hometown-fork / hometown

A supported fork of Mastodon that provides local posting and a wider range of content types.
GNU Affero General Public License v3.0
743 stars 55 forks source link

Responses are not being included in exclusive lists #1354

Open hartsick opened 2 months ago

hartsick commented 2 months ago

Steps to reproduce the problem

  1. Have a list with the following settings, with yourself and at least one other user on the list:
Screenshot 2024-07-09 at 10 33 10 AM
  1. Respond to a message in the list, or have another user you follow respond to a message in that list
  2. See no new messages in the list despite the list settings set to show responses (instead, you'll need to click into the original message to see the response chain)

This also applies to threaded messages (ie self-replies, by you to yourself or another user to themself).

Expected behaviour

Replies to messages in the list from any followed user should also show in the list.

Actual behaviour

No replies (including threaded messages / self-replies from original poster) show up in the list

Detailed description

~Note - this list existed before the recent upgrade and integration of exclusive lists from Mastodon. I haven't looked at code or tried making a new list to reproduce after the merge (or tried with a non-exclusive list), but suspect something is off with the reply settings post-update.~ See comment below for more information. This began happening immediately after the upgrade to v4.2.10+hometown-1.1.1

I'm reporting this as a user, not an admin, so can't currently give any more technical information.

Specifications

Hometown: · v4.2.10+hometown-1.1.1 currently running on friend.camp

hartsick commented 1 month ago

Okay, I have more information on this, but less of an idea about what's going on.

I've just tried replicating this across two instances with the latest version of Hometown installed. On both I made new exclusive lists with replies set to members of the list and added my two accounts across the two servers to it. I then used both accounts to respond to an original message .

One (void.holdings) saw behavior as expected - all responses to the original message showed up in the list. For some reason friend.camp only showed the original message in the list and none of the replies.

I checked on friend.camp and there are no overlapping members of my two exclusive lists.

Screenshots of the feeds after the messages - purple is friend.camp, navy is void.holdings. They should both be the same.

Screenshot 2024-07-24 at 9 05 31 AM Screenshot 2024-07-24 at 9 05 25 AM Screenshot 2024-07-24 at 9 08 23 AM Screenshot 2024-07-24 at 9 08 17 AM