search

homeylab / tdarr-exporter

MIT License
6 stars 0 forks source link

Plans for auth support? #31

Closed Wtfitsaduck closed 3 months ago

Wtfitsaduck commented 3 months ago

Thank you for the great exporter! Do you have any plans on supporting authentication? Tdarr has an option to use auth with API keys. With auth enabled, the exporter naturally does not have access to the webapp and fails all queries.

{"level":"error","error":"failed to execute HTTP Request(http://tdarr-server:8266/api/v2/cruddb): Post \"http://tdarr-server:8266/api/v2/cruddb\": received 40x Status Code: 401","time":"2024-08-07T03:35:13Z","message":"Failed to get data for Tdarr exporter"}
pchang388 commented 3 months ago

hey @Wtfitsaduck - thanks for opening the issue, it should be simple to add auth config/env option. I'll take a look on my on tdarr instance and see if I can get it working and then include it in the next version shortly!

Thanks for raising the issue, will have an update soon!

Wtfitsaduck commented 3 months ago

That's awesome thank you! You can enable Tdarr auth with the auth: true environment variable. You can create an API key from Tools -> API Keys.

pchang388 commented 3 months ago

This is released and working in 1.3.0 version, give it a shot!

Let me know if you see any issues though, thanks!

Wtfitsaduck commented 3 months ago

Thank you for the quick turn around! I just pulled the latest image and it doesn't seem to be working correctly for me. I'm using latest@sha256:967ca0bd072894057baf219e6ef499b65b78a14d70ce54f7eee48320c42e1475 I added the TDARR_API_KEY environment variable with the correct API key but it seems to be still failing. Is there a way I can get debug logs?

{"level":"error","error":"failed to execute HTTP Request(http://tdarr-server:8266/api/v2/cruddb): Post \"http://tdarr-server:8266/api/v2/cruddb\": received 40x Status Code: 401","time":"2024-08-08T15:04:13Z","message":"Failed to get data for Tdarr exporter"}
pchang388 commented 3 months ago

hey @Wtfitsaduck

Try repulling the latest tag image, the latest tag for me in dockerhub is showing up as:

sha256:838bc921c1528cbd35873c3845ea716e8c2741615952230c58146f06084a0307

You can also try referencing the new tag directly instead by using homeylab/tdarr-exporter:1.3.0

Wtfitsaduck commented 3 months ago

Ah maybe I'm blind, but that's not the hash I saw initially. Working now with the correct hash, thank you!