search

homieiot / convention

🏡 The Homie Convention: a lightweight MQTT convention for the IoT
https://homieiot.github.io/
Other
710 stars 59 forks source link

TravisCI markdown checking #146

Open ThomDietrich opened 5 years ago

ThomDietrich commented 5 years ago

How about adding a markdown style check to the CI chain?

I've defined a good remark-lint rule set here: https://github.com/openhab/openhab-docs/blob/gh-pages/package.json

davidgraeff commented 5 years ago

The CI chain on the website end is go and python. Do we really want to introduce a javascript chain as well? (Especially with all those horror messages about npm malware currently in the media)

ThomDietrich commented 5 years ago

Don't know why not. It will only be executed within the isolated environment of TravisCI!? Besides, in terms of testing I believe that a consistent markdown style in the convention and all PRs should be of importance and is worth including in an automated way.

davidgraeff commented 5 years ago

Ok, I'm fine with it

mjcumming commented 4 years ago

@ThomDietrich can this be closed?

davidgraeff commented 4 years ago

The MR is not yet there, is it?