Homie Configurator: JSON values not trimmed

homieiot / homie-esp8266

💡 ESP8266 framework for Homie, a lightweight MQTT convention for the IoT

http://homieiot.github.io/homie-esp8266

MIT License

1.36k stars 308 forks source link

Homie Configurator: JSON values not trimmed #131

Closed euphi closed 7 years ago

euphi commented 8 years ago

The Homie configurator app does not trim the values to send. So it can happen that values contain trailing whitespaces.

Some values are validated (e.g. device-id), some not (e.g. WiFi password).

The app, or maybe even homie-esp8266 itself, should trim the values before sending (and before validating), because most Android keyboards adds a trailing space if a autocomplete feature is active.

marvinroger commented 8 years ago

Alright, I never had such a problem with multiple keyboards (SwiftKey, Fleksy, native...), but trimming value might indeed avoid some trouble. :)

marvinroger commented 7 years ago

Fixed in https://github.com/marvinroger/homie-esp8266-setup/commit/1db4599bcacf3ca7cfec334edeebae4a999926bb