homieiot / homie-esp8266

💡 ESP8266 framework for Homie, a lightweight MQTT convention for the IoT
http://homieiot.github.io/homie-esp8266
MIT License
1.36k stars 308 forks source link

Issue with setMaxTopicLength with dev branch #181

Closed AlexValois closed 7 years ago

AlexValois commented 7 years ago

Hi,

First of all, thank you VERY MUCH for your work. I really like Homie library !

I have just replaced the master (still v1) with the v2 release. After adapting code as mentioned in documentation, I still have an issue with AsyncMQTTClient library when I try to compile the examples or my own sketchs.

The error message is:

Arduino: 1.6.8 (Linux), Board: "NodeMCU 1.0 (ESP-12E Module), 80 MHz, 115200, 4M (3M SPIFFS)"

/root/Arduino/libraries/homie-esp8266-develop/src/Homie/Boot/BootNormal.cpp: In member function 'virtual void HomieInternals::BootNormal::setup()':
/root/Arduino/libraries/homie-esp8266-develop/src/Homie/Boot/BootNormal.cpp:497:44: error: 'class AsyncMqttClient' has no member named 'setMaxTopicLength'
   _interface->mqttClient->setKeepAlive(10).setMaxTopicLength(MAX_MQTT_TOPIC_LENGTH);
                                            ^
exit status 1
Error compiling for board NodeMCU 1.0 (ESP-12E Module).

I have commented following line in BootNormal.cpp (line 497) and it seems to work fine: `_interface->mqttClient->setKeepAlive(10).setMaxTopicLength(MAX_MQTT_TOPIC_LENGTH); I have looked for a new version (or a dev branch for async-mqtt-client) of AsycMQTTClient lib but I did not find any. May I have miss something or is it a bug ?

Thank you

Alex

marvinroger commented 7 years ago

This was implemented 6 days ago, in https://github.com/marvinroger/async-mqtt-client/commit/3f8cc2fe63dd9911e57a83ca0f2a8ffc8805bc16

Download the latest .zip tree and you shoud be fine!

marvinroger commented 7 years ago

And glad you like the project. 😉

AlexValois commented 7 years ago

Ok thanks. I will make a try.

marvinroger commented 7 years ago

@AlexValois any update?

AlexValois commented 7 years ago

With latest versions of async and homie-esp8266, it works fine.

Thank you