search

homieiot / homie-esp8266

💡 ESP8266 framework for Homie, a lightweight MQTT convention for the IoT
http://homieiot.github.io/homie-esp8266
MIT License
1.36k stars 308 forks source link

UTF8 Source Files #414

Open weswitt opened 6 years ago

weswitt commented 6 years ago

The homie-esp8266 source files contain UTF8 characters for many of the logging statements. The source files containing these characters do not have a UTF8 BOM. I see that the root of the source tree contains a .editorconfig file that specifies UTF8, but this is an incomplete solution. This assumes that everyone will read the source code using a specific editor, which is false. The correct thing to do is add the BOM to the source files.

timpur commented 6 years ago

ill look into this.

stritti commented 5 years ago

I think all files are now UTF-8. Could we close this issue?

euphi commented 5 years ago

But they still do not contain a BOM?