search

homieiot / homie-esp8266

💡 ESP8266 framework for Homie, a lightweight MQTT convention for the IoT
http://homieiot.github.io/homie-esp8266
MIT License
1.36k stars 308 forks source link

Choose different subnet for configuration mode IP #56

Closed mountaindude closed 8 years ago

mountaindude commented 8 years ago

The 192.168.1.1 net is quite often used by SOHO routers. Placing a homie device in config mode on that same IP might easily cause conflicts with the user's cable modem/router/Internet gateway.

Maybe something like 192.168.50.1 (or something similarly infrequently used subnet)?

Or provide a way for the developer to define the desired subnet themselves?

mountaindude commented 8 years ago

I guess one could also change the Homie source.. Looks like the 192.168.1.1 is defined in the src/Homie/Boot/BootConfig.cpp file (I am using Homie together with PlatformIO, btw)

mountaindude commented 8 years ago

...then again, changing the access point's IP address to 192.168.50.1 breaks the config tool at http://marvinroger.github.io/homie-esp8266, it seems...

marvinroger commented 8 years ago

The problem is changing the default 192.168.1.1 would be a breaking change. And 192.168.50.1 might also be used by someone else! So yes, maybe we should move the apIp variable to the Constants.hpp, so that it is easily customizable.

It should not break the config tool, it tries to reach http://homie.config, and as you can see, the DNS server is tied to the apIp.

marvinroger commented 8 years ago

Is it enough for you?

mountaindude commented 8 years ago

Yeah it sounds like a good plan.

On 15 April 2016 at 09:29, Marvin Roger notifications@github.com wrote:

Is it enough for you?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/marvinroger/homie-esp8266/issues/56#issuecomment-210328170

marvinroger commented 8 years ago

It will land in v1.4.0. :)

marvinroger commented 8 years ago

Released.