Migrate to ArduinoJson version 6

homieiot / homie-esp8266

💡 ESP8266 framework for Homie, a lightweight MQTT convention for the IoT

http://homieiot.github.io/homie-esp8266

MIT License

1.36k stars 308 forks source link

Migrate to ArduinoJson version 6 #622

Closed mkfrey closed 5 years ago

mkfrey commented 5 years ago

Migrate the code from ArduinoJson v5 to v6
Resolve memory allocation issues resulting from the migration
Reduce unnecessary copying of some JSON related strings
Change to StaticJsonBuffer if possible

MajorTwip commented 5 years ago

Would it be possible to integrate some sort of #606 in this PR?

mkfrey commented 5 years ago

@MajorTwip I will make sure to include it in the pull request for the JSON optimization changes.

iluminat23 commented 5 years ago

I did a test run on my temp-sensor. I can run the configurator and also run it with my preconfigured filesystem.

mkfrey commented 5 years ago

@iluminat23 I committed your proposed changes to the pull request and also made sure to make the linter happy again.

mkfrey commented 5 years ago

AFAIK both commits will be merged separately into the branch on approval. Since the first commit doesn't contain a serious issue, I don't think squashing them would be necessary, but I could do it if you like.

iluminat23 commented 5 years ago

In my projects I would definitely do this. A clean history is a big plus. It makes refactoring or bug hunting mach easier.

mkfrey commented 5 years ago

I squashed the commits.

kleini commented 5 years ago

Will test this, when I have some spare time.