homieiot / homie-esp8266

💡 ESP8266 framework for Homie, a lightweight MQTT convention for the IoT
http://homieiot.github.io/homie-esp8266
MIT License
1.36k stars 308 forks source link

Fix missing "#if HOMIE_MDNS" clause inside BootNormal::_onWifiGotIp #691

Closed thecky closed 3 years ago

thecky commented 3 years ago

There's a missing #if clause, which prevent the homie build for an ESP environment with "-D HOMIE_MDNS=0".

This PR add the missing #if, so that a build with disabled mDNS is possible. The #if clause is missing in these branches:

The PR is only for the develop-branch, but cherry-picking for the other branches should be possible.

Regards, Thomas

kleini commented 3 years ago

LGTM

luebbe commented 3 years ago

Looks good to me ;)