search

homieiot / homie-esp8266

šŸ’” ESP8266 framework for Homie, a lightweight MQTT convention for the IoT
http://homieiot.github.io/homie-esp8266
MIT License
1.36k stars 308 forks source link

Avoid memory clogging when WiFi disconnected #692

Open matzrh opened 3 years ago

matzrh commented 3 years ago

395ff The continous MQTT reconnect attempts - when the WiFi is disconnected - always eat up some memory from the heap. If the WiFI is off for some hours, no memory is left and I get a Exception 29: StoreProhibited: A store referenced a page mapped with an attribute that does not permit stores when the WiFi is reconnecting and the device reboots. I noticed this, since I have the outputs of my ESP8266 control luminaries and they turn on or off hazardously after the WiFi and MQTT reconnects. Some outputs are shared pins with builtin LEDs, but of course the Homie.disableLedFeedback(); does not survive the reboot. The code only attempts to reconnect the MQTT if the WiFi is connected. This way, the memory is not eaten up while the station is offline. Could not test with ESP32 if this needs to / can be done there as well since I do not have one. If it does work as well, the code could be simplified taking out the precompiler directives. 390: since for ESP8266 we have set WiFi.setAutoConnect(true) and WiFi.setAutoReconnect() , it is in my opinion not necessary to explicitly call _wifiConnect(); The WIFI_DISCONNECTED event is fired constantly, anyway (every 3 seconds or so). This however, does not lead to memory clogging.

RunningPenguin commented 3 years ago

I encountered some problems with my H801 LED controllers too. When these lost wifi connection after some time of working like a charm they are making crazy things.

So I pulled your changes on the latest 3.0.1 version in PlatformIO right now and test it with one of my lights. Normal connection/operation is working like expected (perhaps it connects a little bit faster to the wifi and mqtt as before).

If it reconnects properly after a wifi shutdown will try after a few days of normal operation. I will report it here.