homomorfism / data-mining-project

1 stars 0 forks source link

MovieLens 1M downloading and preprocessing is implemented. #9

Closed rizvansky closed 2 years ago

implausibleDeniability commented 2 years ago

You have decode_string implementation both in the notebook and in utils.py. Pls remove one of the copies

implausibleDeniability commented 2 years ago

If chardet lib used in the notebook is not the standard python lib, then add it to the requirements The same for wget lib

implausibleDeniability commented 2 years ago

I also think it's reasonable to remove the zipped file that is downloaded. Nobody will use it

implausibleDeniability commented 2 years ago

@rizvansky Good job!

implausibleDeniability commented 2 years ago

** гитхаб