homothetyhk / RandomizerMod

The newest version of the Hollow Knight item and transition randomizer released for the Hollow Knight 1.5 update.
GNU Lesser General Public License v2.1
48 stars 30 forks source link

Hallownest's Crown / Transition Randomizer broken logic #20

Closed kevingandrews closed 1 year ago

kevingandrews commented 2 years ago

When using transition randomizer, starting at Hallownest's Crown and walking off the left side to the falling transition immediately places everything you encounter through that transition out of logic.

I'm unfamiliar with your code base, but this, specifically the (tuple I think) transition looks to not account for anything except exiting through the bottom.

flibber-hk commented 2 years ago

The explanation of how that works is that only the listed transition (in this case Mines_34[bot1]) is marked as being reachable (except for things which are reachable from that transition). For the same reason, the pale ore check will not be in logic until you can get there from the transition. (As for why [bot1] was chosen instead of [bot2], that would be because you can get to [bot2] from [bot1] with some movement later, so it's sligtly more useful.)

The reason for this behaviour (i.e. only getting a single transition as guaranteed progression) is mainly historical, as the technology to add more things to logic from a start location was not added until fairly recently. That said, this is only a type 2 logic error, so it won't stop seeds from being completable.

homothetyhk commented 1 year ago

Fixed in 5e99a28.