search

homotopy-io / homotopy-webclient

https://homotopy.io
27 stars 5 forks source link

Update react-color once bugs are fixed #120

Open calintat opened 5 years ago

calintat commented 5 years ago

I have downgraded the react-color package to version 2.17.0 because there is a bug in the newer versions which breaks the hex input in BlockPicker. This has been fixed but not released yet (see https://github.com/casesandberg/react-color/issues/651). Once that fix is released, we should update to the latest version.

Also, there is an open pull request in react-color (https://github.com/casesandberg/react-color/pull/583) which adds a 750ms delay to the hex input to give users enough time to enter a 6-digit hex code. Once that fix is merged and released, we could revert my commit b54e758 which stops hiding the colour picker in onChangeComplete.

carlank commented 4 years ago

A fixed version of react-color seems to have been released (2.18.1 is the most current available).

The other PR you mentioned is still open, but I've tested react-color v2.18.1 and the hex input seems to work. I'm not sure what exactly was broken about it before, but I'm going to submit a PR and link it here, if you want to check it out.