search

homotopy-io / homotopy-webclient

https://homotopy.io
27 stars 5 forks source link

Added client/package-lock.json #57

Closed jamievicary closed 5 years ago

jamievicary commented 5 years ago

I have added client/package-lock.json to the repository, since apparently this is best practice. If anybody thinks this is a bad idea please say so!

NickHu commented 5 years ago

I remember reading somewhere that you should have either package-lock.json or yarn.lock but not both; I'm not sure of the details on why.

jamievicary commented 5 years ago

I'm unsure as to best practice here. Everything seems to be working at the moment, so maybe we shouldn't fiddle with it, but I'm open to an expert telling us what to do.

If this project uses yarn why do we need "package-lock.json" at all?

jamievicary commented 5 years ago

Seems to be working well like this, so I'm closing this.