homov / LibMpv

Complete libmpv API wrapper
MIT License
42 stars 4 forks source link

What's new? #6

Closed mysteryx93 closed 11 months ago

mysteryx93 commented 1 year ago

In my version, the code has been completely refactored and restructured https://github.com/mysteryx93/LibMpv-OpenGL

What has been updated here? Since my code is a lot cleaner and better structured, I think that it would be better to work from my code branch.

homov commented 1 year ago

In short:

In my opinion, the wrapper over the API should be as close as possible to the MPV API, since for development you can use examples (ready-made programs) in C and Lua... In your case, it’s difficult to start quickly (since the API is hidden behind wrappers)

You are trying to access all the properties of the MPV player, but still this list is not complete (there are also settings for audio filters, video filters, visualizations.... and many more). It seems to me that this approach is not very optimal. Each project will require its own list of properties. I have implemented the minimum required list of properties to build the player. This minimal list can be easily expanded if necessary in each specific case.

mysteryx93 commented 1 year ago

The strongly-typed API is a separate class over the rest; it's optional and only partially done. Can be done without; but I find that using properties and methods can be rather difficult, particularly those that require structured data!

Most of it is kind of redoing some of refactoring I already did. Any improvements to the core playback?

Particularly anything in the todo list here https://github.com/mysteryx93/LibMpv-OpenGL#contributions-wanted