search

honcheng / PaperFold-for-iOS

Paper folding animation for iOS
Other
2.7k stars 399 forks source link

Fixed issue with autoresizing height #46

Closed cvanderschuere closed 11 years ago

cvanderschuere commented 11 years ago

Allows fold view to resize height on as well as width.

honcheng commented 11 years ago

Thanks. Does the resize problem happens during orientation change? Just wondering how I can test this.

Sent from my iPad

On 9 Jan, 2013, at 4:18 AM, Christopher Vanderschuere notifications@github.com wrote:

Allows fold view to resize height on as well as width.

You can merge this Pull Request by running

git pull https://github.com/cvanderschuere/PaperFold-for-iOS fixes Or view, comment on, or merge it at:

https://github.com/honcheng/PaperFold-for-iOS/pull/46

Commit Summary

Fixed issue with autoresizing File Changes

M PaperFold/PaperFold/PaperFold/MultiFoldView.m (2) Patch Links:

https://github.com/honcheng/PaperFold-for-iOS/pull/46.patch https://github.com/honcheng/PaperFold-for-iOS/pull/46.diff

cvanderschuere commented 11 years ago

Yep. I was running into it after transition from portrait to landscape with a right fold. You can test it by checking the bounds of the contentViewHolder inside a right fold view. Chris On Jan 8, 2013, at 6:28 PM, honcheng notifications@github.com wrote:

Thanks. Does the resize problem happens during orientation change? Just wondering how I can test this.

Sent from my iPad

On 9 Jan, 2013, at 4:18 AM, Christopher Vanderschuere notifications@github.com wrote:

Allows fold view to resize height on as well as width.

You can merge this Pull Request by running

git pull https://github.com/cvanderschuere/PaperFold-for-iOS fixes Or view, comment on, or merge it at:

https://github.com/honcheng/PaperFold-for-iOS/pull/46

Commit Summary

Fixed issue with autoresizing File Changes

M PaperFold/PaperFold/PaperFold/MultiFoldView.m (2) Patch Links:

https://github.com/honcheng/PaperFold-for-iOS/pull/46.patch https://github.com/honcheng/PaperFold-for-iOS/pull/46.diff — Reply to this email directly or view it on GitHub.

honcheng commented 11 years ago

Thanks! I was having problem supporting orientation change.

Sent from my iPhone

On 9 Jan, 2013, at 10:39 AM, Christopher Vanderschuere notifications@github.com wrote:

Yep. I was running into it when made after transition from portrait to landscape with a right fold. You can test it by checking the bounds of the contentViewHolder inside a right fold view. Chris On Jan 8, 2013, at 6:28 PM, honcheng notifications@github.com wrote:

Thanks. Does the resize problem happens during orientation change? Just wondering how I can test this.

Sent from my iPad

On 9 Jan, 2013, at 4:18 AM, Christopher Vanderschuere notifications@github.com wrote:

Allows fold view to resize height on as well as width.

You can merge this Pull Request by running

git pull https://github.com/cvanderschuere/PaperFold-for-iOS fixes Or view, comment on, or merge it at:

https://github.com/honcheng/PaperFold-for-iOS/pull/46

Commit Summary

Fixed issue with autoresizing File Changes

M PaperFold/PaperFold/PaperFold/MultiFoldView.m (2) Patch Links:

https://github.com/honcheng/PaperFold-for-iOS/pull/46.patch https://github.com/honcheng/PaperFold-for-iOS/pull/46.diff — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.