Closed jewel-andraia closed 10 years ago
Good Luck :D
toLowerCase()
in showImages module (@thybag)#514 bitcoinTip's "tip publicly" does not open comment form
I'm merging this, but per the discussion it's a valid point that we should probably look at other .click() calls and test them in Canary, etc. Could this be related to the change that was made regarding FF23? (@andytuba)
#34 Save/unsave doesn't work in multi-reddits
good find, thank you! (@calaveraDeluxe)
#38 Add missing 'nextTip' reference in Tips/Tricks
oops.. good fix.. my bad :-\ (@gavin19)
#110 [feature request] Display all usernames in popdown, and don't remove the current username
I'm pulling this in, but I'l be adding highlighting to it too so you can see the current user you're logged in as... (@Lugghawk)
Haha I'm thankful my miniscule changes aren't included in your changelog @andytuba.
Oh yeah, I gotta make sure to add a line item: "tidying up after us sloppy shmucks -- the eagle-eyed @mc10"
I re-ran the changelog job (updated issue body) but i feel like i'm still missing some issues/PRs that should get logged..
I have to add tag to my PR :D
Edit : I think this new version have around 100 PR (I quickly count). So I think they miss some :p
!!! add a thank you to /u/hamgina for being so nice during 4.3.2.1 chaos
@matheod hrmmmm i updated with new code and a fresh run, but I still feel like there's not enough issues listed.
edit: also i pushed changes to github-changelog
@andytuba Yes, the table PR (#992) is still not here :/
It's getting better. Now i've got issues fixed by commits in the list and some issues fixed by PRs in the list. However, my "PR closed at same time as issue closed ==> PR closed issue" assumption only works about 20% of the time. For the meanwhile, the list includes all closed issues; issues which don't have a concurrent PR have "(fixed?)" appended to the title.
also still need to figure out what to do about @honestbleeps' commits which don't have any issue. should we create issues after the fact and mark them Closed-fixed? pull all commits which don't have an event associated (eg. merged, referenced)?
note to self:
give cookies to matheod
https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/962/events where event=merged, its commit_id matches https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/887/events event=referenced commit_id
this might only work for commits with one commit in the PR?
@andytuba The Author field is wrong sometime.
@matheod can you be more specific please
The two last of Feature request for example.
[WIP] In addition of the changelog, add gif for all new features (only features) : http://imgur.com/a/xjZf3
Ah, #851 and #857 -- Il'l need to tweak it to look at the commit author, not the closing-action actor
<matheod-> Next time you generate your changelog, is this possible your mark thing which don't have Gif-Done tag ?
<andytuba-> sure
<andytuba-> can you make a comment on the hcangelog issue
@honestbleeps @matheod i'm in a rush so i punted and included hopefully everything that was closed. attributions may be incorrect.
Feature Requests
Improvements
Usability Enhancements
Bug Fixes