search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.17k stars 878 forks source link

autoUsernameColor conflicts with userHighlighter highlights #1131

Open hermithome opened 10 years ago

hermithome commented 10 years ago

The biggest place this is an issue is in modmail. I'm not sure why distinguish is auto-on in modmail. After all, most modmail threads are mod only. And for ones that aren't, there is only one non-mod in the thread. It would make more sense to distinguish only the non-mod in modmails. If that's not possible, maybe making it so random colours aren't assigned in modmails. (I've filed this with toolbox as well)

This is also however an issue with OP and OC highlighting. Some colours work...the light blue/purple combination in that image is readable, if not pretty. But you get a lot of combos that just aren't readable. I'd suggest using pale pastels for colour options with a mod or OP highlight. pale yellow, white, pale pink, pale purple---those would all work both against the OP highlight and the mod highlights. Which is good, as a mod can be both OP and need to pull a distinguish.

And for the OC highlight, darker colours would work well.

I know this is a tonne more work...it means one palette for users that aren't highlighted, one for OP/mod highlights and one for OC highlights, but right now, it's really hard to read a lot of names. Colour highlighter is an awesome feature, and it helps me keep track of users...it just doesn't work with highlights.

jewel-andraia commented 10 years ago

These are some interesting points! Highlighting vs autocolor is an issue in white mode, too.

What do you think of just having highlighting text color overriding the user's "random" text color? (For context, a formula is used to generate the user's text color based on their username.)

We could also put some work into trying to generate related-but-compatible colors for "user while highlighted in different states (OP, OC, admin, mod, friend, etc.)". It's an interesting challenge; not a ton of work, but not insignificant.

For reference: Settings > Users > User Highlighter (userHighlight) autoColorUsing - Select a method for setting colors for usernames

hermithome commented 10 years ago

What do you think of just having highlighting text color overriding the user's "random" text color?

Sure, that would work. Would be a bit less pretty, but it would have the necessary functionality. But can we do one better, and for OC, have the random colour become the highlighter colour? In some subs, a large number of OCs reply downthread, and having them all coloured the same can be confusing. Why not make it so that when a person is the OC, the random colour becomes the highlight colour and then the username is either in black (for a light random colour) or white (for a dark random colour)?

jewel-andraia commented 10 years ago

that's a supercool idea. i really like that.

re: mod/op/admin/etc. highlights - how about using the "user's random color" as border color, letting us use normal text color for that highlight

hermithome commented 10 years ago

re: mod/op/admin/etc. highlights - how about using the "user's random color" as border color, letting us use normal text color for that highlight

That sounds good (though it'll work better with some colours than others), but the mod and OP highlights will still need to be modified to be more readable. There are just way, way, way too many names that are totally unreadable when highlighted as an OP or mod

jewel-andraia commented 10 years ago

right - I'm proposing: white/black text, green/blue/red/orangered background, autoRandomColor outline. thus, readable but you still get the hint of the user's assigned color.

hermithome commented 10 years ago

Ahhh, yeah, that would work great.