search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.17k stars 879 forks source link

Remove duplicated HTML/CSS for dialogs in subredditManager.js #1302

Open githue opened 10 years ago

githue commented 10 years ago

I want to combine the 'add shortcut' and 'edit shortcut' forms into one dialog to remove duplicated HTML and CSS with no change to the user experience. It would also free up a few lines in nightmode.css.

Is this worth doing or should I hold off?

jewel-andraia commented 10 years ago

I'm for it. Although that module needs overhaul, this seems like a good small move towards cleaning up.

How ambitious are you feeling? I have some ideas for supporting the ../foo shortcut hack with a select for what kind of shortcut (/r/, /me/m/, /u/, /u/.../m/, or reddit.com/) and maybe which sort/suffix to use (/, /top, /comments, /submitted, etc)

githue commented 10 years ago

I'll leave new features to more skilled coders, I just like to work on markup and usability.

jewel-andraia commented 10 years ago

Fair nuff. Consolidating is a good precursor to my project anyway.

githue commented 10 years ago

Hmm I just remembered @honestbleeps was working on a redesign of the forms.

jewel-andraia commented 10 years ago

I know he wanted to change up the subreddit shortcut edit area by showing a drawer that lets you edit (presumably click to open edit form) and delete.

However, I don't remember any plans from him about updating that particular form..