search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.13k stars 881 forks source link

OneDrive Support #1329

Closed sgtfrankieboy closed 9 years ago

sgtfrankieboy commented 10 years ago

I've figured out a way to support OneDrive. But the method isn't using a publicly available API.

The method will use the query parameters of a OneDrive url and it will then initiate a XMLHttpRequest to an internal OneDrive API which returns a list of all files in that directory or a single file (this allows for some kind of inline image/video gallery). Before I start on it I want to know if this is allowed and that it will not get RES in any trouble.

honestbleeps commented 10 years ago

I'm honestly not sure, we'd have to look at OneDrive's terms and conditions which I'm not able to spend much time reading right at the moment...

sgtfrankieboy commented 10 years ago

I've read through the Microsoft Service Agreement (It was very fun to read...)

And this section sticks out:

7.3. Are there things I can't do with the software or Services? Yes. In addition to the other restrictions in this Agreement, _you may not circumvent or bypass any technological protection measures in or relating to the software or Services or disassemble, decompile, or reverse engineer any software or other aspect of the Services that's included in or accessible through the Services_, except and only to the extent that the applicable copyright law expressly permits doing so; separate components of the software or Services for use on different devices; publish, copy, rent, lease, or lend the software or the Services; or transfer the software, any software licenses, or any rights to access or use the Services. You may not use the Services in any unauthorized way that could interfere with anyone else’s use of them or gain access to any service, data, account, or network. _You may not enable access to the Services by unauthorized third-party applications_.

Seems like it isn't allowed according to that. Unless we just implement it and remove it if Microsoft starts to complain (which I doubt they will).

jewel-andraia commented 10 years ago

Or if Microsoft locks down that pseudo-API, then suddenly RES is broken and that means a month or two of people complaining in /r/resissues.

honestbleeps commented 10 years ago

we should be careful about that... there's an off chance we might be able to get explicit support from them... /u/majornelson lurks /r/xboxone .. perhaps I'll make a post.

On Fri, Jun 27, 2014 at 11:43 AM, sgtfrankieboy notifications@github.com wrote:

I've read through the Microsoft Service Agreement http://windows.microsoft.com/en-gb/windows/microsoft-services-agreement (It was very fun to read...)

And this section sticks out:

7.3. Are there things I can't do with the software or Services? Yes. In addition to the other restrictions in this Agreement, you may not circumvent or bypass any technological protection measures in or relating to the software or Services or disassemble, decompile, or reverse engineer any software or other aspect of the Services that's included in or accessible through the Services, except and only to the extent that the applicable copyright law expressly permits doing so; separate components of the software or Services for use on different devices; publish, copy, rent, lease, or lend the software or the Services; or transfer the software, any software licenses, or any rights to access or use the Services. You may not use the Services in any unauthorized way that could interfere with anyone else’s use of them or gain access to any service, data, account, or network. You may not enable access to the Services by unauthorized third-party applications.

Seems like it isn't allowed according to that. Unless we just implement it and remove it if Microsoft starts to complaining (which I doubt they will).

— Reply to this email directly or view it on GitHub https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/1329#issuecomment-47372534 .

sgtfrankieboy commented 10 years ago

@honestbleeps That might work, but I doubt Major Nelson has any influence over things related to OneDrive because he works at the Xbox department.

Edit: Should I send him a PM anyways or will you send one?

honestbleeps commented 10 years ago

no, but he may know who to talk to / ask! I'm guessing that at least on reddit the primary use of onedrive sharing will be xbox one videos no?

On Fri, Jun 27, 2014 at 11:50 AM, sgtfrankieboy notifications@github.com wrote:

@honestbleeps https://github.com/honestbleeps That might work, but I doubt Major Nelson has any influence over things related to SkyDrive because he works at the Xbox department.

— Reply to this email directly or view it on GitHub https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/1329#issuecomment-47373288 .

sgtfrankieboy commented 10 years ago

Yea, the primary use of OneDrive is sharing Xbox One clips. Not supporting it will also bring some problems with the native mp4 implementation because the urls end with .mp4.

I will send him a PM asking about it. (or you, since you're the owner of RES)

honestbleeps commented 10 years ago

we have URL exclusions for sites that misbehave with .jpg ending URLs that aren't really jpg.. we should use a similar setup for mp4/webm and at least for now, exclude onedrive

On Fri, Jun 27, 2014 at 11:59 AM, sgtfrankieboy notifications@github.com wrote:

Yea, the primary use of OneDrive is sharing Xbox One clips. Not supporting it will also bring some problems with the native mp4 implementation because the urls end with .mp4.

I will send him a PM asking about it. (or you, since you're the owner of RES)

— Reply to this email directly or view it on GitHub https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/1329#issuecomment-47374199 .

sgtfrankieboy commented 10 years ago

Is this PM sufficient?

Hey Larry,

A Reddit extension called RES would like to inline support for OneDrive videos/images, similar to what you see with YouTube and Imgur links. Currently OneDrive is used a lot for sharing Xbox One Gameclips on Reddit and this addition will help a lot of users.

But for this we require permission from Microsoft to make an API request to the OneDrive service which isn't officially documented thus not allowed to be used by third-party applications.

Do you know who we can talk to / ask for this permission? So we can improve the experience of RES users.

Greetings, Frank

sgtfrankieboy commented 10 years ago

Got a reply from Major Nelson:

Hi Frank, Great question. Can you send me an email request and I can work on this? Major at Xbox.com Larry PS I love RES :)

Just send him an email.

honestbleeps commented 10 years ago

awesome! :-D

On Fri, Jun 27, 2014 at 1:18 PM, sgtfrankieboy notifications@github.com wrote:

Got a reply from Major Nelson:

Hi Frank, Great question. Can you send me an email request and I can work on this? Major at Xbox.com Larry PS I love RES :)

Just send him an email, this might work after all.

— Reply to this email directly or view it on GitHub https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/1329#issuecomment-47383172 .

kevinji commented 9 years ago

Fixed by #1333 and #2170.