honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.18k stars 878 forks source link

Clyp.it Expandos do not pause when closing #1654

Closed allthefoxes closed 8 years ago

allthefoxes commented 10 years ago

See here: http://www.reddit.com/r/pics/comments/2hwdje/teen_who_wanted_his_cat_in_his_yearbook_is_joined/ckwmt3s

honestbleeps commented 10 years ago

ugh, related issue: expando can't even be opened if you're using HTTPS, because Chrome complains about mixed content.

jtymes commented 10 years ago

@honestbleeps RESUtils could have a strict match on HTTPS and expandos could check if the host they are attempting to expand is HTTP and open the link in a new tab instead? Could even have a mini expando text explaining why. Seems like a better solution over silently failing. Might be more complicated than it sounds though.

jewel-andraia commented 10 years ago

There's certainly a precedent for "RES could not open this image. Click here to open it."

Saturate commented 10 years ago

I worked on support for gamespot video. Here the same issue applies.

I did send them a ticket about https support, but with no reply yet.

A feature for detection of this would be nice, then I could finish support for the expando.

jpatapoff commented 9 years ago

Clyp co-founder/developer here. For anyone who's familiar with the issue, is this something I can fix on my end? I could listen for an event that fires when the widget element is no longer visible and then subsequently pause the audio file. This would fix this issue, but would cause other problems. For example, if the widget is embedded on someones blog, the user then clicks play and scrolls down the page to look at more content, the the audio file would pause when out of view. I think the result of this hypothetical change would be worse than the situation we're in right now.

I'm thinking a better solution would be to totally remove the widget from the DOM when collapsing the expando.

Thoughts?

@honestbleeps this shouldn't be an issue anymore as we're now 100% HTTPS.

Saturate commented 9 years ago

@jpatapoff I agree, removing the DOM would be a good solution.

larsjohnsen commented 8 years ago

Fixed.

erikdesjardins commented 8 years ago

...in #2903