search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.13k stars 881 forks source link

RES should not run on error pages #2003

Open jewel-andraia opened 9 years ago

jewel-andraia commented 9 years ago

specifically 500s. maybe 400s.

rageandqq commented 9 years ago

What about Night Mode? I'm not the biggest fan of bright screens, and the dark background makes a difference even on error pages.

I haven't delved into how all the different modules work together, but is it possible to only load the module that determines whether night mode (and maybe some other essential features?) is enabled, and not load the rest of RES on error pages?

jewel-andraia commented 9 years ago

Good point. and keyboard nav should still work.

I like that idea! Here's how I'd implement it: RESUtils.pageType() could return "error" on error pages, and certain modules (nightmode, keyboardnav) could include: [ "error" ] and other modules (bettereddit) could exclude: [ "error" ]. maybe some special handling in RESUtils.isMatchURL to only allow modules which specifically list includes: "error" to run on error pages.

andrewboerema commented 5 years ago

@andytuba - is this still a concern now that night mode is a thing in reddit proper?

jewel-andraia commented 5 years ago

Reddit night mode is only available in the redesign, so night mode in old reddit is still a concern