search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.17k stars 878 forks source link

Repost Warning does not refresh when adding a # to the end of a link #2048

Closed allthefoxes closed 9 years ago

allthefoxes commented 9 years ago

A sneaky way to get past a report warning is to add # to the end of a link. While changing the link in any way does update the checker, it seems like adding this # to the end does not

honestbleeps commented 9 years ago

this is a reddit limitation that I'm not sure RES can really get around... unfortunately some sites use hash / hashbang for actual navigation, especially "web application" type sites...

I'm not going to close this, because someone will probably chime in explaining a situation where I'm wrong, which I'm entirely open to... just sharing my first reaction/thought :)

allthefoxes commented 9 years ago

I just mean that, can't RES detect that we have added the # to the link, and check to see if its been posted? Since without the # the warning will come up, with the #, it will On 2/24/2015 4:48 PM, Steve Sobel wrote:

this is a reddit limitation that I'm not sure RES can really get around... unfortunately some sites use hash / hashbang for actual navigation, especially "web application" type sites...

I'm not going to close this, because someone will probably chime in explaining a situation where I'm wrong, which I'm entirely open to... just sharing my first reaction/thought :)

— Reply to this email directly or view it on GitHub https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/2048#issuecomment-75853669.

honestbleeps commented 9 years ago

it could, but the problem is that sometimes it's completely legitimate to add #foobar to a link, that's the tricky part.

a plain # at the end of a link has no real function, but is also not necessarily a nefarious attempt to get around the repost filter, because a lot of sites link to # to scroll to the top or load the "main" part of the app, etc... it's also nontrivial in javascript to remove that "#" in a cross-browser way, which is why RES didn't do it for so long (and the fact that it does do it now actually causes some back/forward nav issues, but I digress)...

basically, it's a tricky situation with no real great answer :-\

allthefoxes commented 9 years ago

No, I understand that par :/

What I am saying is that reddit treats http://example.org as http://example.org#thing as two different things, two different posts.

Example: In subreddit A, User A posts http://example.org

In subreddit A, User B goes to submit http://example.org#thing

User B will see, on the same page, RES's warning about 'That link was already submitted to Subreddit A", however, when he submits the link, he will not get the "Someone already posted that" warning, and will be able to submit just fine.

Are we on the same page here? On 2/24/2015 4:58 PM, Steve Sobel wrote:

it could, but the problem is that sometimes it's completely legitimate to add #foobar to a link, that's the tricky part.

a plain # at the end of a link has no real function, but is also not necessarily a nefarious attempt to get around the repost filter, because a lot of sites link to # to scroll to the top or load the "main" part of the app, etc... it's also nontrivial in javascript to remove that "#" in a cross-browser way, which is why RES didn't do it for so long (and the fact that it does do it now actually causes some back/forward nav issues, but I digress)...

basically, it's a tricky situation with no real great answer :-\

— Reply to this email directly or view it on GitHub https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/2048#issuecomment-75855546.

allthefoxes commented 9 years ago

I'm having issues reproducing anyways, doesn't matter.

erikdesjardins commented 9 years ago

Yeah, submitHelper intentionally removes stuff from the link, including the stuff after #, so it gets the same results for foo.com#bar and foo.com - but it would be easy to stop it from doing that.

It does this because for some reason (I don't know what I was thinking) I didn't verify this claim - I guess it just seemed reasonable enough to believe...

Edit: I really need to stop jumping to conclusions.

erikdesjardins commented 9 years ago

@allthefoxes Are you sure? I get a warning when I try to do it (might have to retract my previous comment):

image

Maybe it doesn't warn you for old posts?

allthefoxes commented 9 years ago

I was able to repost a subreddit with a #, but perhaps I am wrong.

Sorry for the wild goose chase.