search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.15k stars 880 forks source link

Twitter expandos are unstyled on Firefox #2638

Open kevinji opened 8 years ago

kevinji commented 8 years ago

Not sure if it's just my browser, but the expando for https://www.reddit.com/r/nfl/comments/40pfnf/the_rams_are_moving_back_to_los_angeles/ doesn't use our Twitter expando on Firefox. On Chrome, it prompts for the optional permission first before displaying.

githue commented 8 years ago

@allthefoxes had the same issue.

erikdesjardins commented 8 years ago

This is intended, we were breaking AMO rules by injecting that script - see https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/2133#discussion_r26986093

jewel-andraia commented 8 years ago

I'll document that on AutoMod and the known issues.

kevinji commented 8 years ago

Is it possible to style the Twitter expando so it looks similar to the one with injected JavaScript?

jewel-andraia commented 8 years ago

Sure, may as well. We control the markup for it, so don't have to worry about twitter changing it out from under us.