jewel-andraia
commented
11 years ago /* upgrade show and hide to trigger onshow/onhide events when fired. */
(function(show, hide) {
$.fn.show = function(speed, callback) {
$(this).trigger("onshow");
return show.call(this, speed, callback);
}
$.fn.hide = function(speed, callback) {
$(this).trigger("onhide");
return hide.call(this, speed, callback);
}
})($.fn.show, $.fn.hide);In Chrome, modules['commentPreview'].subredditAutocompleteDropdown.show() and modules['commentPreview'].hideSubredditAutocompleteDropdown() invoke these. There doesn't seem to be anything bound to their onshow and onhide events, so they should probably just use the original jQuery methods. Same with any RES calls for $(element).show() / .hide()
P.S. On an unrelated note, hideSubredditAutocompleteDropdown uses $("#subreddit_dropdown") instead of modules['commentPreview'].subredditAutocompleteDropdown.hide(). This seems fragile long-term.
honestbleeps
ghost
patricksnape
Voting, loading comments, editing flair, etc. -- all sorts of stock reddit ajaxy stuff is broken in Opera -- at least, in v12.14.
In Opera, extensions kinda run in the page context instead of sandboxed like the other browsers. Although RES's internal copy of jquery.reddit.js appears to override reddit's
$.requestfor reddit JS calls (like "load more comments"), RES's copy of$.requestdoesn't have access to page global variables likereddit.This is fixed by not re-defining
$.requestinside of RES. I'll investigate to determine if RES in other browsers actually uses this functionality and if I can pare it down or tear it out completely.