search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.13k stars 881 forks source link

Add debug button to show RES settings in a comment #357

Open patricksnape opened 11 years ago

patricksnape commented 11 years ago

Suggestion:

Add whether or not the user is using night mode to the list of config information in RESIssues. Night mode seems to come with it's own host of issues and I'm wondering if automatically flagging whether or not a user is using it would be helpful?

ghost commented 11 years ago

Ideally, I'd like to extend that to an option to show all the RES settings a user has.

You wouldn't want that in every post, but a debug button to insert it into a comment would be useful.

On Fri, Apr 12, 2013 at 12:03 PM, Patrick Snape notifications@github.comwrote:

Suggestion:

Add whether or not the user is using night mode to the list of config information in RESIssues. Nightmode seems to come with it's own host of issues and I'm wondering if automatically flagging whether or not a user is using it would be helpful?

— Reply to this email directly or view it on GitHubhttps://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/357 .

Regards, Tim Collins

honestbleeps commented 11 years ago

great idea. can't hurt anything!

On Fri, Apr 12, 2013 at 6:03 AM, Patrick Snape notifications@github.comwrote:

Suggestion:

Add whether or not the user is using night mode to the list of config information in RESIssues. Nightmode seems to come with it's own host of issues and I'm wondering if automatically flagging whether or not a user is using it would be helpful?

— Reply to this email directly or view it on GitHubhttps://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/357 .

patricksnape commented 11 years ago

I'm interested in implementing this - but feel like it would be a separate module that only shows up for RESIssues and Enhancement. However, I'm reluctant to add a new module before we split the modules apart. Thoughts? @honestbleeps Shall I slap a pull request up for my module split branch? Or do we want to discuss the modularity better before we start splitting it up?

Although, having thought about it, you might be waiting until you iron out all the hotfixes before splitting it up, which is fair enough really.

ghost commented 11 years ago

Yeah, I saw it as a module only for /r/resissues. Some sort of giant 'post my diagnostic info' button that churns stuff out into a comment in that subreddit only.

Regards, Tim Collins

This email was sent using a mobile device.

On 12 Apr 2013, at 20:17, Patrick Snape notifications@github.com wrote:

I'm interested in implementing this - but feel like it would be a separate module that only shows up for RESIssues and Enhancement. However, I'm reluctant to add a new module before we split the modules apart. Thoughts? @honestbleeps Shall I slap a pull request up for my module split branch? Or do we want to discuss the modularity better before we start splitting it up?

Although, having thought about it, you might be waiting until you iron out all the hotfixes before splitting it up, which is fair enough really.

— Reply to this email directly or view it on GitHub.

patricksnape commented 11 years ago

@tico24 Yeah, I can see from browsing RESIssues that this would be a truly massive boon. Would it be better to list ALL options, or just those that differ from the defaults?

ghost commented 11 years ago

I think all.

It'll make it easier for you to maintain too because the defaults change from release to release.

Regards, Tim Collins

This email was sent using a mobile device.

On 12 Apr 2013, at 20:26, Patrick Snape notifications@github.com wrote:

@tico24 Yeah, I can see from browsing RESIssues that this would be a truly massive boon. Would it be better to list ALL options, or just those that differ from the defaults?

— Reply to this email directly or view it on GitHub.

honestbleeps commented 11 years ago

I've been wanting to discuss something related to this anyway... join us in

enhancement on snoonet when you're able :-)

On Fri, Apr 12, 2013 at 2:32 PM, Tim Collins notifications@github.comwrote:

I think all.

It'll make it easier for you to maintain too because the defaults change from release to release.

Regards, Tim Collins

This email was sent using a mobile device.

On 12 Apr 2013, at 20:26, Patrick Snape notifications@github.com wrote:

@tico24 Yeah, I can see from browsing RESIssues that this would be a truly massive boon. Would it be better to list ALL options, or just those that differ from the defaults?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/357#issuecomment-16312938 .

honestbleeps commented 11 years ago

yeah, hotfixes first, then split for sure... I do want to get there, but there's definitely some more fixes that need to get out :-\

thoughts on module settings info: output should be human readable stuff, not JSON, for a variety of reasons we discussed on IRC earlier.

On Fri, Apr 12, 2013 at 2:17 PM, Patrick Snape notifications@github.comwrote:

I'm interested in implementing this - but feel like it would be a separate module that only shows up for RESIssues and Enhancement. However, I'm reluctant to add a new module before we split the modules apart. Thoughts? @honestbleeps https://github.com/honestbleeps Shall I slap a pull request up for my module split branch? Or do we want to discuss the modularity better before we start splitting it up?

Although, having thought about it, you might be waiting until you iron out all the hotfixes before splitting it up, which is fair enough really.

— Reply to this email directly or view it on GitHubhttps://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/357#issuecomment-16312155 .