search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.13k stars 881 forks source link

Reddit Enhancement Suite does nothing #3728

Closed inunah closed 7 years ago

inunah commented 7 years ago

What's the problem? When RES is enabled, nothing changes. No expandos, night mode is gone, and all of my extra features aren't there. This was not happening prior to the release of 5.2.0.

I have disabled all of my extensions except for RES. I have reinstalled the extension. I have restarted my browser. I have restarted my computer. I have disabled then enabled RES. None of these things resulted in any change or resolution.

Are there any related posts in https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues or /r/RESissues? Yes. https://www.reddit.com/r/RESissues/comments/5gq5c2/res_is_not_loading_up/

What other browser extensions are installed? C.H.I.P. Flasher (flashes C.H.I.P and PocketC.H.I.P. devices to a new firmware) Easy SteamGifts (enables one-click entering for giveaways on steamgifts.com) Magic Actions for YouTube (enhances YouTube with a customizeable theater experience) New XKit (enhances all of Tumblr's features) Reddit Enhancement Suite (you know this one) Smile Always (redirects all Amazon URLs to their smile.amazon.com equivalents) Steam Database (adds database info to every Steam store page) Stylish (allows you to customize any website's CSS - has not been used for Reddit) uBlock Origin (adblocker)

Ajedi32 commented 7 years ago

Could you go to Reddit, open the JavaScript console (Ctrl + Shift + J), refresh the page, and take a screenshot?

One user in the linked Reddit thread provided the following screenshot: Uncaught (in promise) TypeError: Object.values is not a function It'd be interesting to see if you're getting a similar error. (FYI, the line referenced in that error message is here.)

Also, have you enabled any flags in chrome://flags/? In particular, it's possible #enable-javascript-harmony or #disable-javascript-harmony-shipping might cause problems.

inunah commented 7 years ago

Got an identical error.

image

I did not have #enable-javascript-harmony enabled, so I enabled it. No change. I did not have #disable-javascript-harmony-shipping enabled, so I enabled it. No change. I enabled both of them together. No change. I re-disabled them.

I had #enable-experimental-canvas-features enabled, so I disabled it. No change. I had #disable-accelerated-2d-canvas enabled, so I disabled it. No change. I had #enable-fast-unload enabled, so I disabled it. No change, so I re-enabled it. I had #disable-hyperlink-auditing enabled, so I disabled it. No change, so I re-enabled it.

At this point I realized I had to restart for each change, so I restarted Chrome.

Suddenly, the issue was fixed. One or both of those two canvas features was the problem, I'm guessing.

Ajedi32 commented 7 years ago

Yeah, random flags being enabled has broken stuff for people in past releases as well. When Chrome says "Careful, these experiments may bite" they really do mean it. Perhaps we should add "go to chrome://flags/, click Reset all to default then restart your computer" to our list of standard troubleshooting steps.

kevinji commented 7 years ago

Closing, as issue was fixed.