search

honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.15k stars 879 forks source link

Link to media hosts' privacy policy #4983

Open jewel-andraia opened 5 years ago

jewel-andraia commented 5 years ago

In the interest of fairness to RES users and all the platforms RES draws on, the RES team should add options to each media host linking to their privacy policy and noting "telemetry may be collected by this host for analytics."

This could be implemented as simply adding for each media host {hostName}privacyPolicy: button option: (Read privacy Policy) - This media host may be collecting analytical data on user activity while viewing their content.

Spin off from https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/4982

Atrolantra commented 5 years ago

Heya, I'd be keen to give this issue a crack. Haven't worked on this project before though so if you could give me a little bit more info on where/how to add the button to each host module that'd be awesome.

Also where would this button appear to users? It'll help me verify I've implemented this correctly; I'm not fully understanding at the moment. Cheers

jewel-andraia commented 5 years ago

Awesome, thanks for volunteering!

For starters, we just need to compile the list of links.

The button itself should appear in the res settings console in the Inline Image Viewer, grouped with the other options for the media host. Each media host site had at least a "enable expandos for [given site]".

Atrolantra commented 5 years ago

Awesome, thanks for the help. I've gotten started on it over here.

I whipped up one for gfycat real quick, current looks like this: GitHub Logo

Any changes you'd like to that before I go through and add it to all the media hosts?

jewel-andraia commented 5 years ago

Looks awesome, carry on!