honestbleeps / Reddit-Enhancement-Suite

Reddit Enhancement Suite
http://redditenhancementsuite.com
GNU General Public License v3.0
4.17k stars 877 forks source link

Markdown does not render properly #5218

Open frakman1 opened 4 years ago

frakman1 commented 4 years ago

What's the problem?

Someone left me a comment with syntax highlighted markdown. To them and anyone else on the internet, it looks like this:

image

However, for me, it looks like this.

image

I've tried toggling all my extensions off/on in chrome://extensions/ but no change after refreshing the page. It only works when I open the page in incognito.

Are there any related posts in https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues or /r/RESissues?

Not to my knowledge

What other browser extensions are installed?

image image image

benmcgarry commented 4 years ago

Can you link the post please?

benmcgarry commented 4 years ago

This looks to be a platform issue rather than RES. With RES disabled it shows the same as we are not doing any formatting. It looks like the comment was made on the redesign and hasn't formatted back to old.

@andytuba Does backwards compat for FPE > old reddit exist?

jewel-andraia commented 4 years ago

As Ben alluded to, triple backtick code blocks are only rendered correctly on redesign 😥

frakman1 commented 4 years ago

@BenMcGarry Sure. Here is the offending link

If it's a platform issue, then why does it work when I go into incognito mode? What redesign are you referencing? Is that a RES thing or a Reddit thing?

jewel-andraia commented 4 years ago

@frakman1 "old reddit": https://old.reddit.com/r/gitlab/comments/dvdm3n/has_anyone_successfully_used_code_climate_in/fpf97au/

Screen Shot 2020-05-04 at 17 54 23

"redesign" (what incognito defaults to): https://new.reddit.com/r/gitlab/comments/dvdm3n/has_anyone_successfully_used_code_climate_in/fpf97au/

Screen Shot 2020-05-04 at 17 54 25

These are two different website frontends, which render differently.

frakman1 commented 4 years ago

Ahh I "see" now. Thank you for laying it out so clearly. I did express a preference for using the old.reddit via the preferences option. I hate the new redesign with all its wasted space.

image

So does this mean that markdown will never render properly with old reddit, or is this something that RES can possibly, one-day handle?

jewel-andraia commented 4 years ago

Ideally Reddit Inc would add backtick support to old reddit or use four-space codeblocks instead, although I'm not optimistic about seeing that any time soon. RES could potentially bridge this gap, one day.

YodaEmbedding commented 3 years ago

Duplicate of https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/5223. (Clearer title.)