Settings modal with language, mode and accent MVP

honey-protocol / honey-frontend-legacy

🍯 An open source interface for the Honey Finance protocol

https://honey-frontend.vercel.app

MIT License

31 stars 21 forks source link

Settings modal with language, mode and accent MVP #145

Closed tinybigideas closed 2 years ago

tinybigideas commented 2 years ago

closes https://github.com/honey-labs/honey-frontend/issues/151

Initial MVP for settings modal. Give us a skeleton for: Language options (not implement, just setting). Mode options ('dark', 'light') and Accent options ('orange', 'yellow', 'blue', 'green', 'indigo', 'pink', 'purple', 'red', 'teal').

Stores in LocalStorage for later use. Wiring up the set/get but only Mode and Accent is implemented in this pass.

Questions:

Do we want to disable logo clicking for accent with this PR or keep in place?
Do we have an idea of which languages we'd want to support? My proposition is to create standalone language const files for all content (each language const could be its own job posting opportunity for community members)
Do we want to extend language support to full locale support? I.e. date formats changed too

Screenshots

vercel[bot] commented 2 years ago

@tinybigideas is attempting to deploy a commit to the Honey Labs Team on Vercel.

A member of the Team first needs to authorize it.

BowTiedHeron commented 2 years ago

Note to the team; don't merge this PR yet. There is a pending bounty we need to setup for this before moving forward with any merging.

@tinybigideas this looks dope! I will review more in depth with @tomjpandolfi later and provide some feedback! Thanks a lot for your efforts so far :)

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
honey-dev-env	✅ Ready (Inspect)	Visit Preview	Jun 29, 2022 at 2:38PM (UTC)
honey-frontend	✅ Ready (Inspect)	Visit Preview	Jun 29, 2022 at 2:38PM (UTC)

oshioked commented 2 years ago

Really nice work. Everything works fine. Here are a few suggestions I think would make this better.

For the settings, a dropdown close to the settings btn would be nice. Doesn't have to be the full-screen modal
The light/dark transition is smooth but there are some adjustments that are needed to accommodate the light theme.

Like with the bg color of the farm cards.

The governance page also. The bg of the HIP cards container

Then maybe a border for the modal inner to give it some distinction

These are just some I noticed. You could still go through to check if there are others. Really nice work mate.