honey-team / ufpy

Ufpy (Useful Python) - package for Python with some useful features
https://honey-team.github.io/ufpy-website
MIT License
3 stars 3 forks source link

fix sourcery's suggestions #22

Closed bleudev closed 5 months ago

bleudev commented 5 months ago

closes #21

Summary by Sourcery

This pull request addresses several issues in the UDict class, including fixing dictionary initialization, item setting logic, length calculation, iteration, and boolean checks. Additionally, new tests have been added to verify these fixes and ensure proper exception handling.

sourcery-ai[bot] commented 5 months ago

Reviewer's Guide by Sourcery

This pull request addresses issue #21 by implementing several suggestions from Sourcery to improve the code quality and functionality of the UDict class and its associated tests. The changes include refactoring code for better readability, adding new test cases, and fixing existing ones.

File-Level Changes

Files Changes
tests/test_udict.py
ufpy/udict.py
Refactored methods for better readability and efficiency, added new test cases, and fixed existing ones to ensure comprehensive coverage and correct functionality.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
bleudev commented 5 months ago

@sourcery-ai review