search

honeybadger-io / honeybadger-js

Universal JavaScript library for reporting errors to Honeybadger.io :zap:
https://www.honeybadger.io/for/javascript/
MIT License
109 stars 62 forks source link

Use a code formatter #1112

Open BethanyBerkowitz opened 1 year ago

BethanyBerkowitz commented 1 year ago

Using Prettier would help us have code that's... prettier. By enforcing a standard, it would also remove the annoying whitespace changes that we often see popping up in PRs just because two different developers have slightly different settings in their text editors or IDEs.

There are other formatters out there, but Prettier is the most popular and most people are familiar with it. I also like that it's opinionated so we don't need to have a lot of back-and-forth on config options.

subzero10 commented 1 year ago

I was hoping that we would achieve the desired formatting styles just by using eslint, but it seems that it's not true 🤷.

BethanyBerkowitz commented 1 year ago

I was hoping that we would achieve the desired formatting styles just by using eslint, but it seems that it's not true 🤷.

The existing eslint setup is definitely really helpful! But yeah, formatters and linters are good at different things, so it's pretty common to have both. I don't think this is an urgent problem for us, though. It would become more urgent if we regularly had a larger group of people pushing code.