search

honeybadger-io / honeybadger-python

Send Python and Django errors to Honeybadger.
https://www.honeybadger.io/
MIT License
15 stars 25 forks source link

Missing fingerprint in honeybadger.notify #115

Closed nadnerb closed 1 year ago

nadnerb commented 2 years ago

The python library seems to be missing a fingerprint which is available in the ruby gem and API. This makes using notify not as flexible when reporting errors using honeybadger.notify.

joshuap commented 2 years ago

@subzero10, @Kelvin4664 can probably help with this one if you can provide some direction.

Edit: (This milestone has the issues I'd ultimately like to complete in the near-future.)

subzero10 commented 2 years ago

@nadnerb This should be fixed with v0.10.0!

nadnerb commented 1 year ago

Sorry for the late reply. Thank you! I will try it asap.

subzero10 commented 1 year ago

@nadnerb I just released v0.11.0 making fingerprint a top-level function parameter (https://github.com/honeybadger-io/honeybadger-python/pull/117). Note: it's a breaking change from v0.10.0

nadnerb commented 1 year ago

Hey @subzero10. Thanks for all the work and sorry for the slow response, I haven't been 100%. I noticed you put fingerprint at the method level in the error_payload method. However it has not been added to the notify method in v0.11.0?

Thanks again.

nadnerb commented 1 year ago

@subzero10, @joshuap, would you like me to raise another bug for the notify issue?

subzero10 commented 1 year ago

@nadnerb No need, I will get to it today!

subzero10 commented 1 year ago

@nadnerb PR ready! cc @joshuap

subzero10 commented 1 year ago

@nadnerb v0.12.0 is released with the fingerprint in the notify method!

nadnerb commented 1 year ago

Fantastic, thank you!