Closed Mng-dev-ai closed 1 year ago
@Kelvin4664 Can you please take a look at this? Thanks!
@Kelvin4664 are the tests failing because of my pr? I can see It's coming from fastapi
@Kelvin4664 are the tests failing because of my pr? I can see It's coming from fastapi
Hey @Mng-dev-ai, have you tried running them locally? What if you checkout master branch and run them? I can see here that they passed last time they ran on master.
Hey @subzero10, ya I tried running them on the master branch locally and got the same error
Hey @subzero10, ya I tried running them on the master branch locally and got the same error
Found the issue. It seems that we need to install httpx with the latest version of fastapi. https://github.com/honeybadger-io/honeybadger-python/pull/126
Hey @Mng-dev-ai, can you please rebase/merge with master? This should fix the current issue with the tests.
@subzero10 Done.
Published with v0.14.0
!
Thank you @Mng-dev-ai and @Kelvin4664!
Release v0.14.0 is broken! It has an unmet dependency: celery. Go figure!
Release v0.14.0 is broken! It has an unmet dependency: celery. Go figure!
😱 @Mng-dev-ai Can you make the plugin conditional? Something like:
try:
from honeybadger.contrib.celery import CeleryHoneybadger
hasCelery = True
except ImportError as err:
hasCelery = False
Or is there a better approach for this?
cc @Kelvin4664
@subzero10 oh right, added a PR to fix it here
Resolves #61