why are Flask dependencies installed on Django build?

honeybadger-io / honeybadger-python

Send Python and Django errors to Honeybadger.

https://www.honeybadger.io/

MIT License

15 stars 25 forks source link

why are Flask dependencies installed on Django build? #144

Open dotysan opened 1 year ago

dotysan commented 1 year ago

Example Job

Or more specifically, why does this script blindly install Flask dependencies--and even Flask itself--when $FLASK_VERSION isn't set.

subzero10 commented 1 year ago

Hey @Kelvin4664, any thoughts on this?

dotysan commented 1 year ago

I've simplified the script in this branch, and am having no issues with CI.

subzero10 commented 1 year ago

@dotysan Can you please create PR from your branch to see what's been done and what's pending? It seems that you are tackling a couple of open issues, let's see if can address them all with a single PR.

dotysan commented 1 year ago

Done in fresh branch here #153. Take a peek and review!