honeybadger-io / honeybadger-python

Send Python and Django errors to Honeybadger.
https://www.honeybadger.io/
MIT License
15 stars 25 forks source link

Add Makefile for env, dev, and django example #145

Open dotysan opened 1 year ago

dotysan commented 1 year ago
subzero10 commented 1 year ago

Hey @dotysan, thanks for submitting this PR!

There's already an issue #127 to use a dependency manager, what is your opinion on using Make + pip vs the other options listed in the issue?

dotysan commented 1 year ago

Well...a small/simple Makefile with venv is just my personal crutch. It's mostly out of habit. And just because I can easily read/edit/execute it.

I really don't have much experience with Pipenv, Poetry, PDM.

I did, however, bootstrap a pip module with Flit last month and it worked swimmingly! I also enjoyed tinkering with Hatch, but in the end Flit met my simple needs.

In a different branch, I'm in the process of moving tests to tox and requirements out of setup.py into pip --require files for both dev and test. Maybe after that, this will all be moot...

subzero10 commented 1 year ago

Well...a small/simple Makefile with venv is just my personal crutch. It's mostly out of habit. And just because I can easily . > read/edit/execute it.

I really don't have much experience with Pipenv, Poetry, PDM.

I see your point, though it means the Makefile needs to be maintained as the package evolves. I would like to explore at least one of these dependency management tools first.

I did, however, bootstrap a pip module with Flit last month and it worked swimmingly! I also enjoyed tinkering with Hatch, but in the end Flit met my simple needs.

I didn't know about Flit, we use Twine to deploy this package :).

In a different branch, I'm in the process of moving tests to tox and requirements out of setup.py into pip --require files for both dev and test. Maybe after that, this will all be moot...

I guess we should wait for that branch then, right?

dotysan commented 1 year ago

I've moved all the heavy lifting into tox here. #153

And I still use the lightweight Makefile for only constructing my local dev/venv, dependencies, and repetitive tasks.