search

honeybadger-io / honeybadger-python

Send Python and Django errors to Honeybadger.
https://www.honeybadger.io/
MIT License
15 stars 25 forks source link

Remove deepcopy #173

Closed stympy closed 2 months ago

stympy commented 2 months ago

Fixes #172

Kelvin4664 commented 2 months ago

@joshuap We added deepcopy to fix #165, which is a far less critical bug than this one. I think it makes sense to remove since that bug was a user error and we were only trying to make the system fail safe.

Kelvin4664 commented 2 months ago

Also, i believe directly reverting that PR will be a better approach here. I have opened #174 for that. Someone take a look before i merge.

stympy commented 2 months ago

I think it makes sense to keep the removal of keys that are tuples, but the way that it was done could be improved (this PR), so I'm going to go with this to fix the issue, and we can revisit if necessary.

subzero10 commented 2 months ago

I think it makes sense to keep the removal of keys that are tuples

+1